diff --git a/lms/djangoapps/courseware/courses.py b/lms/djangoapps/courseware/courses.py index fbc96a4dac..3d524699e7 100644 --- a/lms/djangoapps/courseware/courses.py +++ b/lms/djangoapps/courseware/courses.py @@ -187,7 +187,7 @@ def get_course_about_section(course, section_key): loc, field_data_cache, course.id, - not_found_ok=True, + log_if_not_found=False, wrap_xmodule_display=False, static_asset_path=course.static_asset_path ) @@ -241,6 +241,7 @@ def get_course_info_section(request, course, section_key): usage_key, field_data_cache, course.id, + log_if_not_found=False, wrap_xmodule_display=False, static_asset_path=course.static_asset_path ) diff --git a/lms/djangoapps/courseware/module_render.py b/lms/djangoapps/courseware/module_render.py index aaa1e02814..5c2db2b68b 100644 --- a/lms/djangoapps/courseware/module_render.py +++ b/lms/djangoapps/courseware/module_render.py @@ -140,7 +140,7 @@ def toc_for_course(user, request, course, active_chapter, active_section, field_ def get_module(user, request, usage_key, field_data_cache, - position=None, not_found_ok=False, wrap_xmodule_display=True, + position=None, log_if_not_found=True, wrap_xmodule_display=True, grade_bucket_type=None, depth=0, static_asset_path=''): """ @@ -152,11 +152,13 @@ def get_module(user, request, usage_key, field_data_cache, - user : User for whom we're getting the module - request : current django HTTPrequest. Note: request.user isn't used for anything--all auth and such works based on user. - - location : A Location-like object identifying the module to load + - usage_key : A UsageKey object identifying the module to load - field_data_cache : a FieldDataCache - - course_id : the course_id in the context of which to load module - position : extra information from URL for user-specified position within module + - log_if_not_found : If this is True, we log a debug message if we cannot find the requested xmodule. + - wrap_xmodule_display : If this is True, wrap the output display in a single div to allow for the + XModule javascript to be bound correctly - depth : number of levels of descendents to cache when loading this module. None means cache all descendents - static_asset_path : static asset path to use (overrides descriptor's value); needed @@ -176,9 +178,10 @@ def get_module(user, request, usage_key, field_data_cache, grade_bucket_type=grade_bucket_type, static_asset_path=static_asset_path) except ItemNotFoundError: - if not not_found_ok: - log.exception("Error in get_module") + if log_if_not_found: + log.debug("Error in get_module: ItemNotFoundError") return None + except: # Something has gone terribly wrong, but still not letting it turn into a 500. log.exception("Error in get_module")