From 1131edc9a235dc69cb65460833732fc87ea34536 Mon Sep 17 00:00:00 2001 From: John Eskew Date: Wed, 29 Jun 2016 11:37:00 -0400 Subject: [PATCH] Change test to reflect how XBlock handles control chars. --- common/lib/xmodule/xmodule/tests/test_video.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/common/lib/xmodule/xmodule/tests/test_video.py b/common/lib/xmodule/xmodule/tests/test_video.py index e11147a43b..12c4042c87 100644 --- a/common/lib/xmodule/xmodule/tests/test_video.py +++ b/common/lib/xmodule/xmodule/tests/test_video.py @@ -752,11 +752,12 @@ class VideoExportTestCase(VideoDescriptorTestBase): def test_export_to_xml_invalid_characters_in_attributes(self): """ - Test XML export will raise TypeError by lxml library if contains illegal characters. + Test XML export will *not* raise TypeError by lxml library if contains illegal characters. + The illegal characters in a String field are removed from the string instead. """ - self.descriptor.display_name = '\x1e' - with self.assertRaises(ValueError): - self.descriptor.definition_to_xml(None) + self.descriptor.display_name = 'Display\x1eName' + xml = self.descriptor.definition_to_xml(None) + self.assertEqual(xml.get('display_name'), 'DisplayName') def test_export_to_xml_unicode_characters(self): """