From 1cbd5e65d9d689e9f168d028f493e1c4862ed2c2 Mon Sep 17 00:00:00 2001 From: michaelroytman Date: Tue, 24 Jan 2023 16:14:58 -0500 Subject: [PATCH] fix: upgrade lti-consumer-xblock library to install PII sharing dialog fixes This commit upgrades the version of the lti-consumer-xblock library from version 7.2.2 to version 7.2.3. This new version contains a fix to the LTI PII sharing consent dialog. Please see the CHANGELOG entry for this version for a full description of the fixes: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst#723---2023-01-24. The commit message is included below for convenience. This commit fixes a bug in the PII sharing consent dialog. The bug resulted in bizarre behavior when there were more than one LTI component in a unit. For example, if there were two LTI inline launches in a unit, two "OK" button would appear in a single component, instead of in their respective components. Another example is that clicking the "View resource in a [modal|new] window" buttons under two LTI components resulted in the "OK" and "Cancel" buttons as well as the PII sharing prompt appearing in a single component, instead of in their respective components. This is because the dialog-container div that is dynamically created in the Javascript was not scoped to the LTI component, so there was a div with a id of "dialog-container" for each component configured to share PII. When dynamically inserting and removing buttons and the PII sharing prompt, the Javascript would simply find the first div with the dialog-container ID and operate on it, instead of the div appropriate to the component the user is interacting with. --- requirements/edx/base.txt | 2 +- requirements/edx/development.txt | 2 +- requirements/edx/testing.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/requirements/edx/base.txt b/requirements/edx/base.txt index 3bf7a971c2..a8b30efc53 100644 --- a/requirements/edx/base.txt +++ b/requirements/edx/base.txt @@ -665,7 +665,7 @@ libsass==0.10.0 # ora2 loremipsum==1.0.5 # via ora2 -lti-consumer-xblock==7.2.2 +lti-consumer-xblock==7.2.3 # via -r requirements/edx/base.in lxml==4.9.2 # via diff --git a/requirements/edx/development.txt b/requirements/edx/development.txt index 487722962a..6f7284ff3b 100644 --- a/requirements/edx/development.txt +++ b/requirements/edx/development.txt @@ -891,7 +891,7 @@ loremipsum==1.0.5 # via # -r requirements/edx/testing.txt # ora2 -lti-consumer-xblock==7.2.2 +lti-consumer-xblock==7.2.3 # via -r requirements/edx/testing.txt lxml==4.9.2 # via diff --git a/requirements/edx/testing.txt b/requirements/edx/testing.txt index 836576ffd5..d58d070f68 100644 --- a/requirements/edx/testing.txt +++ b/requirements/edx/testing.txt @@ -849,7 +849,7 @@ loremipsum==1.0.5 # via # -r requirements/edx/base.txt # ora2 -lti-consumer-xblock==7.2.2 +lti-consumer-xblock==7.2.3 # via -r requirements/edx/base.txt lxml==4.9.2 # via