From 0faa6837762c27f0643f834f8e695f94eddde51b Mon Sep 17 00:00:00 2001 From: Calen Pennington Date: Tue, 8 Aug 2017 10:59:21 -0400 Subject: [PATCH] Update access to deprecated enrollment.course (which now doesn't create the CourseOverview transparently) --- common/djangoapps/student/models.py | 3 +-- lms/djangoapps/certificates/signals.py | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/common/djangoapps/student/models.py b/common/djangoapps/student/models.py index 93c14d1f43..0ad0b544d1 100644 --- a/common/djangoapps/student/models.py +++ b/common/djangoapps/student/models.py @@ -1009,7 +1009,6 @@ class CourseEnrollment(models.Model): else: self._course_id = value - created = models.DateTimeField(auto_now_add=True, null=True, db_index=True) # If is_active is False, then the student is not considered to be enrolled @@ -1678,7 +1677,7 @@ class CourseEnrollment(models.Model): If the course is re-published within the lifetime of this CourseEnrollment object, then the value of this property will become stale. - """ + """ if not self._course_overview: try: self._course_overview = CourseOverview.get_from_id(self.course_id) diff --git a/lms/djangoapps/certificates/signals.py b/lms/djangoapps/certificates/signals.py index 1f66adf2d7..fd29abc4c4 100644 --- a/lms/djangoapps/certificates/signals.py +++ b/lms/djangoapps/certificates/signals.py @@ -88,11 +88,11 @@ def _listen_for_track_change(sender, user, **kwargs): # pylint: disable=unused- user_enrollments = CourseEnrollment.enrollments_for_user(user=user) grade_factory = CourseGradeFactory() for enrollment in user_enrollments: - if grade_factory.read(user=user, course=enrollment.course).passed: - if fire_ungenerated_certificate_task(user, enrollment.course.id): + if grade_factory.read(user=user, course=enrollment.course_overview).passed: + if fire_ungenerated_certificate_task(user, enrollment.course_id): log.info(u'Certificate generation task initiated for {user} : {course} via track change'.format( user=user.id, - course=enrollment.course.id + course=enrollment.course_id ))