diff --git a/lms/djangoapps/instructor_task/tasks_helper.py b/lms/djangoapps/instructor_task/tasks_helper.py index 093f68fc40..36f4e6bd18 100644 --- a/lms/djangoapps/instructor_task/tasks_helper.py +++ b/lms/djangoapps/instructor_task/tasks_helper.py @@ -57,7 +57,6 @@ from opaque_keys.edx.keys import UsageKey from openedx.core.djangoapps.course_groups.cohorts import add_user_to_cohort, is_course_cohorted from student.models import CourseEnrollment, CourseAccessRole from verify_student.models import SoftwareSecurePhotoVerification -from util.query import use_read_replica_if_available # define different loggers for use within tasks and on client side TASK_LOG = logging.getLogger('edx.celery.task') @@ -1262,7 +1261,7 @@ def generate_students_certificates( that are enrolled. """ start_time = time() - enrolled_students = use_read_replica_if_available(CourseEnrollment.objects.users_enrolled_in(course_id)) + enrolled_students = CourseEnrollment.objects.users_enrolled_in(course_id) task_progress = TaskProgress(action_name, enrolled_students.count(), start_time) current_step = {'step': 'Calculating students already have certificates'} @@ -1386,7 +1385,7 @@ def students_require_certificate(course_id, enrolled_students): :param enrolled_students: """ # compute those students where certificates already generated - students_already_have_certs = use_read_replica_if_available(User.objects.filter( + students_already_have_certs = User.objects.filter( ~Q(generatedcertificate__status=CertificateStatuses.unavailable), - generatedcertificate__course_id=course_id)) + generatedcertificate__course_id=course_id) return list(set(enrolled_students) - set(students_already_have_certs)) diff --git a/lms/templates/certificates/_accomplishment-banner.html b/lms/templates/certificates/_accomplishment-banner.html index 5f643754f5..c920d9c808 100644 --- a/lms/templates/certificates/_accomplishment-banner.html +++ b/lms/templates/certificates/_accomplishment-banner.html @@ -76,7 +76,7 @@ from django.core.urlresolvers import reverse %endif % if share_settings.get('CERTIFICATE_TWITTER', False): - <% twitter_url = 'https://twitter.com/intent/tweet?text=' + twitter_share_text + '&url='+ share_url%> + <% twitter_url = 'https://twitter.com/intent/tweet?text=' + twitter_share_text + '&url='+ urllib.quote_plus(share_url)%>