From 0e9136589f62f654ade50c674887ec20120e7f4a Mon Sep 17 00:00:00 2001 From: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com> Date: Wed, 8 Feb 2023 17:50:46 +0500 Subject: [PATCH] fix: remove programUpsell from api response (#31729) VAN-1298 Co-authored-by: Syed Sajjad Hussain Shah --- .../learner_recommendations/serializers.py | 15 +-------------- lms/djangoapps/learner_recommendations/views.py | 1 - 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/lms/djangoapps/learner_recommendations/serializers.py b/lms/djangoapps/learner_recommendations/serializers.py index 14b21de6cb..c8c747cdb3 100644 --- a/lms/djangoapps/learner_recommendations/serializers.py +++ b/lms/djangoapps/learner_recommendations/serializers.py @@ -39,25 +39,12 @@ class RecommendedCourseSerializer(serializers.Serializer): return f"course/{url_slug}" -class RecommendedProgramSerializer(serializers.Serializer): - """Serializer for a recommended program for course about page recommendations""" - title = serializers.CharField() - marketingUrl = serializers.URLField(source="marketing_url") - coursesCount = serializers.IntegerField(source="courses_count") - pacingType = serializers.CharField(source="pacing_type") - weeksToComplete = serializers.CharField(source="weeks_to_complete") - minHours = serializers.IntegerField(source="min_hours") - maxHours = serializers.IntegerField(source="max_hours") - type = serializers.CharField() - - class RecommendationsSerializer(serializers.Serializer): - """Recommended courses and program for course about page""" + """Recommended courses for course about page""" courses = serializers.ListField( child=RecommendedCourseSerializer(), allow_empty=True ) - programUpsell = RecommendedProgramSerializer(source="program_upsell") isControl = serializers.BooleanField( source="is_control", default=None diff --git a/lms/djangoapps/learner_recommendations/views.py b/lms/djangoapps/learner_recommendations/views.py index 4ad01d0ff4..0f7b4553eb 100644 --- a/lms/djangoapps/learner_recommendations/views.py +++ b/lms/djangoapps/learner_recommendations/views.py @@ -148,7 +148,6 @@ class AmplitudeRecommendationsView(APIView): return Response( RecommendationsSerializer( { - "program_upsell": None, "courses": recommended_courses, "is_control": is_control, }