Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor!: remove md4 and related ENABLE_BLAKE2B_HASHING feature flag

Browse Source
This commit is contained in:
Muhammad Anas
2024-12-20 10:17:34 +05:00
parent 81f825ff15
commit 0de7569b68
5 changed files with 3 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
common/djangoapps/util/tests/test_memcache.py
View File

@@ -3,15 +3,11 @@ Tests for memcache in util app
"""
from django.conf import settings
from django.core.cache import caches
from django.test import TestCase, override_settings
from django.test import TestCase
from common.djangoapps.util.memcache import safe_key
BLAKE2B_ENABLED_FEATURES = settings.FEATURES.copy()
BLAKE2B_ENABLED_FEATURES["ENABLE_BLAKE2B_HASHING"] = True
class MemcacheTest(TestCase):
"""
@@ -55,20 +51,6 @@ class MemcacheTest(TestCase):
# The key should now be valid
assert self._is_valid_key(key), f'Failed for key length {length}'
@override_settings(FEATURES=BLAKE2B_ENABLED_FEATURES)
def test_safe_key_long_with_blake2b_enabled(self):
# Choose lengths close to memcached's cutoff (250)
for length in [248, 249, 250, 251, 252]:
# Generate a key of that length
key = 'a' * length
# Make the key safe
key = safe_key(key, '', '')
# The key should now be valid
assert self._is_valid_key(key), f'Failed for key length {length}'
def test_long_key_prefix_version(self):
# Long key
@@ -83,34 +65,6 @@ class MemcacheTest(TestCase):
key = safe_key('key', 'prefix', 'a' * 300)
assert self._is_valid_key(key)
@override_settings(FEATURES=BLAKE2B_ENABLED_FEATURES)
def test_long_key_prefix_version_with_blake2b_enabled(self):
# Long key
key = safe_key('a' * 300, 'prefix', 'version')
assert self._is_valid_key(key)
# Long prefix
key = safe_key('key', 'a' * 300, 'version')
assert self._is_valid_key(key)
# Long version
key = safe_key('key', 'prefix', 'a' * 300)
assert self._is_valid_key(key)
def test_safe_key_unicode(self):
for unicode_char in self.UNICODE_CHAR_CODES:
# Generate a key with that character
key = chr(unicode_char)
# Make the key safe
key = safe_key(key, '', '')
# The key should now be valid
assert self._is_valid_key(key), f'Failed for unicode character {unicode_char}'
def test_safe_key_prefix_unicode(self):
for unicode_char in self.UNICODE_CHAR_CODES: