From 0b7a5431643413f9f8d90b3fa00235e8d3258673 Mon Sep 17 00:00:00 2001 From: Muhammad Arslan Abdul Rauf Date: Tue, 16 Dec 2025 20:36:11 +0500 Subject: [PATCH] test: update tests related to deleting draft xblock --- xmodule/modulestore/tests/test_publish.py | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/xmodule/modulestore/tests/test_publish.py b/xmodule/modulestore/tests/test_publish.py index 545dbc250e..e07f985790 100644 --- a/xmodule/modulestore/tests/test_publish.py +++ b/xmodule/modulestore/tests/test_publish.py @@ -810,14 +810,8 @@ class ElementalDeleteItemTests(DraftPublishedOpBaseTestSetup): self.assertOLXIsDraftOnly(block_list_to_delete) # MODULESTORE_DIFFERENCE: if self.is_split_modulestore: - if revision in (ModuleStoreEnum.RevisionOption.published_only, ModuleStoreEnum.RevisionOption.all): - # Split throws an exception when trying to delete an item from the published branch - # that isn't yet published. - with pytest.raises(ValueError): - self.delete_item(block_list_to_delete, revision=revision) - else: - self.delete_item(block_list_to_delete, revision=revision) - self._check_for_item_deletion(block_list_to_delete, result) + self.delete_item(block_list_to_delete, revision=revision) + self._check_for_item_deletion(block_list_to_delete, result) else: raise Exception("Must test either Old Mongo or Split modulestore!") @@ -846,11 +840,8 @@ class ElementalDeleteItemTests(DraftPublishedOpBaseTestSetup): # The vertical is a draft. self.assertOLXIsDraftOnly(block_list_to_delete) if revision in (ModuleStoreEnum.RevisionOption.published_only, ModuleStoreEnum.RevisionOption.all): - # MODULESTORE_DIFFERENCE: - # Split throws an exception when trying to delete an item from the published branch - # that isn't yet published. - with pytest.raises(ValueError): - self.delete_item(block_list_to_delete, revision=revision) + self.delete_item(block_list_to_delete, revision=revision) + self._check_for_item_deletion(block_list_to_delete, result) else: self.delete_item(block_list_to_delete, revision=revision) self._check_for_item_deletion(block_list_to_delete, result)