From 0b48665ad21e4bac34f0bf2583e2c0fa5e5401c9 Mon Sep 17 00:00:00 2001 From: Jeremy Bowman Date: Tue, 14 May 2019 16:10:46 -0400 Subject: [PATCH] Fix flaky tab reordering test (#20555) --- .../acceptance/tests/studio/test_studio_tabs.py | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/common/test/acceptance/tests/studio/test_studio_tabs.py b/common/test/acceptance/tests/studio/test_studio_tabs.py index 79b261810c..c251cdfb0d 100644 --- a/common/test/acceptance/tests/studio/test_studio_tabs.py +++ b/common/test/acceptance/tests/studio/test_studio_tabs.py @@ -127,18 +127,11 @@ class PagesTest(StudioCourseTest): 'Tabs are not in the default order' ) self.pages_page.drag_and_drop(default_tab=True) - built_in_page_titles = self.pages_page.built_in_page_titles - self.assertEqual( - built_in_page_titles, - new_order, - 'Tabs are not in the new order' - ) + self.pages_page.wait_for(lambda: self.pages_page.built_in_page_titles == new_order, + 'Tabs are in the new order') self.pages_page.refresh_and_wait_for_load() - self.assertEqual( - built_in_page_titles, - new_order, - 'Tabs are not in the new order' - ) + self.pages_page.wait_for(lambda: self.pages_page.built_in_page_titles == new_order, + 'Tabs are in the new order') def test_users_can_toggle_visibility(self): """