From 09cb944801a21947dc6959b231b46bc971ae222c Mon Sep 17 00:00:00 2001 From: Ahtisham Shahid Date: Thu, 21 Mar 2024 15:44:49 +0500 Subject: [PATCH] fix: removed cohorts filter from reported notifications (#34369) --- .../discussion/rest_api/discussions_notifications.py | 5 ++--- ...ns_notifications.py => test_discussions_notifications.py} | 2 ++ lms/djangoapps/discussion/rest_api/tests/test_tasks.py | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) rename lms/djangoapps/discussion/rest_api/tests/{test_disucssions_notifications.py => test_discussions_notifications.py} (96%) diff --git a/lms/djangoapps/discussion/rest_api/discussions_notifications.py b/lms/djangoapps/discussion/rest_api/discussions_notifications.py index da5b430fce..988ea25c87 100644 --- a/lms/djangoapps/discussion/rest_api/discussions_notifications.py +++ b/lms/djangoapps/discussion/rest_api/discussions_notifications.py @@ -306,10 +306,9 @@ class DiscussionNotificationSender: 'content_type': content_type, 'content': thread_body } - audience_filters = self._create_cohort_course_audience() - audience_filters['discussion_roles'] = [ + audience_filters = {'discussion_roles': [ FORUM_ROLE_ADMINISTRATOR, FORUM_ROLE_MODERATOR, FORUM_ROLE_COMMUNITY_TA - ] + ]} self._send_course_wide_notification("content_reported", audience_filters, context) diff --git a/lms/djangoapps/discussion/rest_api/tests/test_disucssions_notifications.py b/lms/djangoapps/discussion/rest_api/tests/test_discussions_notifications.py similarity index 96% rename from lms/djangoapps/discussion/rest_api/tests/test_disucssions_notifications.py rename to lms/djangoapps/discussion/rest_api/tests/test_discussions_notifications.py index 1156440b6d..adc8235d43 100644 --- a/lms/djangoapps/discussion/rest_api/tests/test_disucssions_notifications.py +++ b/lms/djangoapps/discussion/rest_api/tests/test_discussions_notifications.py @@ -54,6 +54,8 @@ class TestDiscussionNotificationSender(unittest.TestCase): self.assertEqual(audience_filters, { 'discussion_roles': ['Administrator', 'Moderator', 'Community TA'] }) + self.assertEqual(len(audience_filters), 1) + self.assertEqual(list(audience_filters.keys()), ['discussion_roles']) def test_send_reported_content_notification_for_response(self, mock_send_notification, mock_create_audience): """ diff --git a/lms/djangoapps/discussion/rest_api/tests/test_tasks.py b/lms/djangoapps/discussion/rest_api/tests/test_tasks.py index acb8da294f..824bff2962 100644 --- a/lms/djangoapps/discussion/rest_api/tests/test_tasks.py +++ b/lms/djangoapps/discussion/rest_api/tests/test_tasks.py @@ -563,7 +563,7 @@ class TestResponseEndorsedNotifications(DiscussionAPIViewTestMixin, ModuleStoreT def test_response_endorsed_notifications(self): """ - Tests nresponse endorsed notifications + Tests response endorsed notifications """ thread = ThreadMock(thread_id=1, creator=self.user_1, title='test thread')