From 084b4096626cf148d2a77871109856208736732d Mon Sep 17 00:00:00 2001 From: Awais Jibran Date: Thu, 12 Mar 2020 15:15:22 +0500 Subject: [PATCH] Unnecessary logs. --- common/lib/xmodule/xmodule/library_content_module.py | 5 +---- lms/djangoapps/discussion/views.py | 9 --------- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/common/lib/xmodule/xmodule/library_content_module.py b/common/lib/xmodule/xmodule/library_content_module.py index 963efcad75..647e603c9c 100644 --- a/common/lib/xmodule/xmodule/library_content_module.py +++ b/common/lib/xmodule/xmodule/library_content_module.py @@ -306,10 +306,7 @@ class LibraryContentModule(LibraryContentFields, XModule, StudioEditableModule): current user. """ for block_type, block_id in self.selected_children(): - child = self.runtime.get_block(self.location.course_key.make_usage_key(block_type, block_id)) - if child is None: - logger.info("Child not found for %s %s", str(block_type), str(block_id)) - yield child + yield self.runtime.get_block(self.location.course_key.make_usage_key(block_type, block_id)) def student_view(self, context): fragment = Fragment() diff --git a/lms/djangoapps/discussion/views.py b/lms/djangoapps/discussion/views.py index a4bb67aab4..7f41a24166 100644 --- a/lms/djangoapps/discussion/views.py +++ b/lms/djangoapps/discussion/views.py @@ -370,16 +370,10 @@ def _find_thread(request, course, discussion_id, thread_id): response_limit=request.GET.get("resp_limit") ) except cc.utils.CommentClientRequestError: - log.info(u"Discussion Error: Thread ID:{thread_id} not found for Discussion: {discussion_id}".format( - thread_id=thread_id, discussion_id=discussion_id) - ) return None # Verify that the student has access to this thread if belongs to a course discussion module thread_context = getattr(thread, "context", "course") if thread_context == "course" and not utils.discussion_category_id_access(course, request.user, discussion_id): - log.info(u'Discussion Error: Thread Context:{context} for thread: {thread}'.format( - context=thread_context, thread=thread.__dict__) - ) return None # verify that the thread belongs to the requesting student's group @@ -388,9 +382,6 @@ def _find_thread(request, course, discussion_id, thread_id): if is_commentable_divided(course.id, discussion_id, course_discussion_settings) and not is_moderator: user_group_id = get_group_id_for_user(request.user, course_discussion_settings) if getattr(thread, "group_id", None) is not None and user_group_id != thread.group_id: - log.info(u"Discussion Error: user_group:{user_group} is not equal to thread_group:{thread_group}".format( - user_group=user_group_id, thread_group=thread.group_id - )) return None return thread