From 07c54dcbaa539d4968483bc2524329009ecb4b15 Mon Sep 17 00:00:00 2001 From: Andy Armstrong Date: Wed, 2 Apr 2014 18:18:59 -0400 Subject: [PATCH] Fix up edit_component so that it doesn't take an unnecessary step argument --- cms/djangoapps/contentstore/features/component.py | 4 ++-- .../features/component_settings_editor_helpers.py | 6 +++--- cms/djangoapps/contentstore/features/html-editor.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cms/djangoapps/contentstore/features/component.py b/cms/djangoapps/contentstore/features/component.py index 0e8b7f9b5c..e700c49df6 100644 --- a/cms/djangoapps/contentstore/features/component.py +++ b/cms/djangoapps/contentstore/features/component.py @@ -169,11 +169,11 @@ def change_display_name(step, display_name): world.edit_component_and_select_settings() index = world.get_setting_entry_index(DISPLAY_NAME) world.set_field_value(index, display_name) - world.save_component(step) + world.save_component() @step(u'I unset the display name') def unset_display_name(step): world.edit_component_and_select_settings() world.revert_setting_entry(DISPLAY_NAME) - world.save_component(step) + world.save_component() diff --git a/cms/djangoapps/contentstore/features/component_settings_editor_helpers.py b/cms/djangoapps/contentstore/features/component_settings_editor_helpers.py index 84187d1c80..5bf3264a3f 100644 --- a/cms/djangoapps/contentstore/features/component_settings_editor_helpers.py +++ b/cms/djangoapps/contentstore/features/component_settings_editor_helpers.py @@ -133,7 +133,7 @@ def enter_xml_in_advanced_problem(step, text): """ world.edit_component() type_in_codemirror(0, text) - world.save_component(step) + world.save_component() @world.absorb @@ -183,14 +183,14 @@ def verify_all_setting_entries(expected_entries): @world.absorb -def save_component(step): +def save_component(): world.css_click("a.action-save") world.wait_for_ajax_complete() @world.absorb def save_component_and_reopen(step): - save_component(step) + save_component() # We have a known issue that modifications are still shown within the edit window after cancel (though) # they are not persisted. Refresh the browser to make sure the changes WERE persisted after Save. reload_the_page(step) diff --git a/cms/djangoapps/contentstore/features/html-editor.py b/cms/djangoapps/contentstore/features/html-editor.py index 4a39eb299f..8b1717e617 100644 --- a/cms/djangoapps/contentstore/features/html-editor.py +++ b/cms/djangoapps/contentstore/features/html-editor.py @@ -123,7 +123,7 @@ def perform_action_in_plugin(action): @step('I save the page$') def i_click_on_save(step): - world.save_component(step) + world.save_component() @step('the page text contains:')