diff --git a/lms/djangoapps/simplewiki/views.py b/lms/djangoapps/simplewiki/views.py index e31f826378..0b78fcd264 100644 --- a/lms/djangoapps/simplewiki/views.py +++ b/lms/djangoapps/simplewiki/views.py @@ -88,7 +88,6 @@ def root_redirect(request, course_id): try: root = Article.get_root(course.wiki_namespace) except: - #TODO: If we don't find a root article, we should create it err = not_found(request, '/') return err @@ -465,10 +464,10 @@ def encode_err(request, url, course): d.update(csrf(request)) return render_to_response('simplewiki/simplewiki_error.html', d) -def not_found(request, wiki_url, course): +def not_found(request, article_path, course): """Generate a NOT FOUND message for some URL""" d = {'wiki_err_notfound': True, - 'wiki_url': wiki_url, + 'article_path': article_path, 'course' : course, 'namespace' : course.wiki_namespace} d.update(csrf(request)) @@ -481,7 +480,6 @@ def get_article(request, article_path, course): try: article = Article.get_article(article_path) except Article.DoesNotExist, ValueError: - #TODO: We need to pass a url for creating the article here err = not_found(request, article_path, course) return (article, err) diff --git a/lms/templates/simplewiki/simplewiki_error.html b/lms/templates/simplewiki/simplewiki_error.html index ded668a649..9610423b2c 100644 --- a/lms/templates/simplewiki/simplewiki_error.html +++ b/lms/templates/simplewiki/simplewiki_error.html @@ -3,7 +3,8 @@ <%inherit file="simplewiki_base.html"/> <%! - from django.core.urlresolvers import reverse + from django.core.urlresolvers import reverse + from simplewiki.views import wiki_namespace_reverse %> <%block name="title">Wiki Error – MITx 6.002x @@ -21,10 +22,10 @@ ${wiki_error} %endif %if wiki_err_notfound is not UNDEFINED: - %if wiki_url is not UNDEFINED: + %if article_path is not UNDEFINED:

The page you requested could not be found. - Click here to create it. + Click here to create it.

%else:

@@ -35,13 +36,7 @@ ${wiki_error}

%endif %else: -%if wiki_err_noparent is not UNDEFINED: -

- You cannot create this page, because its parent - does not exist. Click here - to create it. -

-%elif wiki_err_no_namespace is not UNDEFINED and wiki_err_no_namespace: +%if wiki_err_no_namespace is not UNDEFINED and wiki_err_no_namespace:

You must specify a namespace to create an article in.

diff --git a/lms/urls.py b/lms/urls.py index 21dab292a0..28da01ad28 100644 --- a/lms/urls.py +++ b/lms/urls.py @@ -90,18 +90,16 @@ if settings.COURSEWARE_ENABLED: namespace = r'/(?P' + namespace_regex + r')' urlpatterns += ( url(r'^courses/(?P[^/]*)/wiki/$', 'simplewiki.views.root_redirect', name='wiki_root'), - url(r'^courses/(?P[^/]*)/wiki/view' + article_slug + r'/?$', 'simplewiki.views.view', name='wiki_view'), - url(r'^courses/(?P[^/]*)/wiki/view_revision/(?P[0-9]+)' + article_slug + r'/?$', 'simplewiki.views.view_revision', name='wiki_view_revision'), - url(r'^courses/(?P[^/]*)/wiki/edit' + article_slug + r'/?$', 'simplewiki.views.edit', name='wiki_edit'), - url(r'^courses/(?P[^/]*)/wiki/create' + article_slug + r'/?$', 'simplewiki.views.create', name='wiki_create'), - url(r'^courses/(?P[^/]*)/wiki/history' + article_slug + r'(?:/(?P[0-9]+))?/?$', 'simplewiki.views.history', name='wiki_history'), - url(r'^courses/(?P[^/]*)/wiki/search_related' + article_slug + r'/?$', 'simplewiki.views.search_add_related', name='search_related'), + url(r'^courses/(?P[^/]*)/wiki/view' + article_slug, 'simplewiki.views.view', name='wiki_view'), + url(r'^courses/(?P[^/]*)/wiki/view_revision/(?P[0-9]+)' + article_slug, 'simplewiki.views.view_revision', name='wiki_view_revision'), + url(r'^courses/(?P[^/]*)/wiki/edit' + article_slug, 'simplewiki.views.edit', name='wiki_edit'), + url(r'^courses/(?P[^/]*)/wiki/create' + article_slug, 'simplewiki.views.create', name='wiki_create'), + url(r'^courses/(?P[^/]*)/wiki/history' + article_slug + r'(?:/(?P[0-9]+))?$', 'simplewiki.views.history', name='wiki_history'), + url(r'^courses/(?P[^/]*)/wiki/search_related' + article_slug, 'simplewiki.views.search_add_related', name='search_related'), url(r'^courses/(?P[^/]*)/wiki/random/?$', 'simplewiki.views.random_article', name='wiki_random'), - url(r'^courses/(?P[^/]*)/wiki/revision_feed/([0-9]+)/?$', 'simplewiki.views.revision_feed', name='wiki_revision_feed'), - url(r'^courses/(?P[^/]*)/wiki/search' + namespace + r'?/?$', 'simplewiki.views.search_articles', name='wiki_search_articles'), - url(r'^courses/(?P[^/]*)/wiki/list' + namespace + r'?/?$', 'simplewiki.views.search_articles', name='wiki_list_articles'), #Just an alias for the search, but you usually don't submit a search term - - + url(r'^courses/(?P[^/]*)/wiki/revision_feed/([0-9]+)$', 'simplewiki.views.revision_feed', name='wiki_revision_feed'), + url(r'^courses/(?P[^/]*)/wiki/search' + namespace + r'?$', 'simplewiki.views.search_articles', name='wiki_search_articles'), + url(r'^courses/(?P[^/]*)/wiki/list' + namespace + r'?$', 'simplewiki.views.search_articles', name='wiki_list_articles'), #Just an alias for the search, but you usually don't submit a search term )