From 0481d9a0b11905398eb6aee098e7e649c8af3a03 Mon Sep 17 00:00:00 2001 From: Muhammad Faraz Maqsood Date: Wed, 26 Nov 2025 21:17:48 +0500 Subject: [PATCH] fix: accessibility issue on video transcripts (#37587) This commit fixes accessibility issue for video transcripts as when a video component's SRT file has an empty line, the transcript has an empty link that is still interactive. Empty links should not be interactive and should be hidden from keyboard users as it takes extra click for them when an empty line occurs in the transcript. Co-authored-by: Muhammad Faraz Maqsood --- xmodule/static/css-builtin-blocks/VideoBlockDisplay.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xmodule/static/css-builtin-blocks/VideoBlockDisplay.css b/xmodule/static/css-builtin-blocks/VideoBlockDisplay.css index 9584a1dc76..401a798804 100644 --- a/xmodule/static/css-builtin-blocks/VideoBlockDisplay.css +++ b/xmodule/static/css-builtin-blocks/VideoBlockDisplay.css @@ -708,6 +708,10 @@ line-height: lh(); } +.xmodule_display.xmodule_VideoBlock .video .subtitles .subtitles-menu li:has(> span:empty) { + display: none; +} + .xmodule_display.xmodule_VideoBlock .video .subtitles .subtitles-menu li span { display: block; }