From 7a3ead747ed395a010fa7a0f78dcadd11e3bb4eb Mon Sep 17 00:00:00 2001 From: Diana Huang Date: Thu, 17 Dec 2020 11:10:12 -0500 Subject: [PATCH 1/3] Upgrade python requirements. --- requirements/edx-sandbox/py35.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements/edx-sandbox/py35.txt b/requirements/edx-sandbox/py35.txt index d92baa9757..7a7f5724ec 100644 --- a/requirements/edx-sandbox/py35.txt +++ b/requirements/edx-sandbox/py35.txt @@ -20,7 +20,7 @@ matplotlib==2.2.4 # via -c requirements/edx-sandbox/../constraints.txt, mpmath==1.1.0 # via sympy networkx==2.2 # via -r requirements/edx-sandbox/py35.in nltk==3.5 # via -r requirements/edx-sandbox/shared.txt, chem -numpy==1.16.5 # via -c requirements/edx-sandbox/../constraints.txt, -r requirements/edx-sandbox/py35.in, chem, matplotlib, openedx-calc, scipy +numpy==1.16.5 # via -c requirements/edx-sandbox/../constraints.txt, -r requirements/edx-sandbox/py35.in, chem, matplotlib, openedx-calc openedx-calc==1.0.9 # via -r requirements/edx-sandbox/py35.in pycparser==2.20 # via -r requirements/edx-sandbox/shared.txt, cffi pyparsing==2.2.0 # via -r requirements/edx-sandbox/py35.in, chem, matplotlib, openedx-calc From a4ca84e92aa2e1ece6ec8505e71268e928fa227b Mon Sep 17 00:00:00 2001 From: Diana Huang Date: Thu, 17 Dec 2020 11:48:20 -0500 Subject: [PATCH 2/3] Add DJANGO_SETTINGS_MODULE to pylint runs. --- pavelib/quality.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pavelib/quality.py b/pavelib/quality.py index ca05a7def3..f5bd679c90 100644 --- a/pavelib/quality.py +++ b/pavelib/quality.py @@ -137,11 +137,13 @@ def _get_pylint_violations(systems=ALL_SYSTEMS.split(','), errors_only=False, cl system_report = report_dir / 'pylint.report' if clean or not system_report.exists(): sh( + "export DJANGO_SETTINGS_MODULE={env}.envs.test; " "pylint {flags} --output-format=parseable {apps} " "> {report_dir}/pylint.report".format( flags=" ".join(flags), apps=apps_list, - report_dir=report_dir + report_dir=report_dir, + env=('cms' if system == 'cms' else 'lms') ), ignore_error=True, ) From f6085e51393c805abaf51fae7de1e6e7dc8a084c Mon Sep 17 00:00:00 2001 From: Diana Huang Date: Fri, 18 Dec 2020 12:26:12 -0500 Subject: [PATCH 3/3] Bump threshold limits due to previously broken pylint. --- scripts/thresholds.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/thresholds.sh b/scripts/thresholds.sh index c3d9fecbf7..92a4c39648 100755 --- a/scripts/thresholds.sh +++ b/scripts/thresholds.sh @@ -2,6 +2,6 @@ set -e export LOWER_PYLINT_THRESHOLD=1000 -export UPPER_PYLINT_THRESHOLD=2400 +export UPPER_PYLINT_THRESHOLD=7050 export ESLINT_THRESHOLD=5300 export STYLELINT_THRESHOLD=880