From 2caafb22f177f8204705561be1a2f5f7db6dcc01 Mon Sep 17 00:00:00 2001
From: Ahsan Ulhaq <ahsan.haq@arbisoft.com>
Date: Thu, 26 Feb 2015 20:50:29 +0500
Subject: [PATCH 1/2] Missing accessible label in lms <nav> elements.

many of the nav elements in the lms dont have the accessible labels

TNL-1554
---
 lms/templates/courseware/course_about.html                  | 2 +-
 .../dashboard/_dashboard_prompt_midcourse_reverify.html     | 4 ++--
 lms/templates/discussion/user_profile.html                  | 2 +-
 lms/templates/staticbook.html                               | 2 +-
 .../verify_student/midcourse_photo_reverification.html      | 2 +-
 lms/templates/verify_student/photo_reverification.html      | 6 +++---
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/lms/templates/courseware/course_about.html b/lms/templates/courseware/course_about.html
index 29967f7b34..b297bf2b8a 100644
--- a/lms/templates/courseware/course_about.html
+++ b/lms/templates/courseware/course_about.html
@@ -206,7 +206,7 @@ from edxmako.shortcuts import marketing_link
         </div>
       % endif
 
-      <nav>
+      <nav aria-label="${_('Course About')}">
         <a href="#" class="active">${_("Overview")}</a>
       ##  <a href="#">${_("FAQ")}</a>
       ##  <a href="#">${_("Requirements")}</a>
diff --git a/lms/templates/dashboard/_dashboard_prompt_midcourse_reverify.html b/lms/templates/dashboard/_dashboard_prompt_midcourse_reverify.html
index f1615a40fa..fb62add365 100644
--- a/lms/templates/dashboard/_dashboard_prompt_midcourse_reverify.html
+++ b/lms/templates/dashboard/_dashboard_prompt_midcourse_reverify.html
@@ -23,7 +23,7 @@
             </ul>
           </div>
         </div>
-        <nav class="nav-actions">
+        <nav class="nav-actions" aria-label="${_('Notification Actions')}">
           <h3 class="sr">${_('Notification Actions')}</h3>
           <ul>
             <li class="nav-item"><a class="btn action-primary action-reverify" href="${reverse('verify_student_midcourse_reverify_dash')}">Re-verify</a></li>
@@ -47,7 +47,7 @@
             </p>
           </div>
         </div>
-        <nav class="nav-actions">
+        <nav class="nav-actions" aria-label="${_('Notification Actions')}">
           <h3 class="sr">${_('Notification Actions')}</h3>
           <ul>
             <li class="nav-item"><a class="btn action-primary action-reverify" href="${reverse('verify_student_midcourse_reverify_dash')}">Re-verify</a></li>
diff --git a/lms/templates/discussion/user_profile.html b/lms/templates/discussion/user_profile.html
index 03b3aa71f3..c13711279b 100644
--- a/lms/templates/discussion/user_profile.html
+++ b/lms/templates/discussion/user_profile.html
@@ -23,7 +23,7 @@
 <section class="container">
   <div class="course-wrapper">
     <section aria-label="${_('User Profile')}" class="user-profile">
-      <nav>
+      <nav aria-label="${_('User Profile')}">
 
         <article class="sidebar-module discussion-sidebar">
           <%include file="_user_profile.html" />
diff --git a/lms/templates/staticbook.html b/lms/templates/staticbook.html
index 23bf425850..5664adcf3e 100644
--- a/lms/templates/staticbook.html
+++ b/lms/templates/staticbook.html
@@ -110,7 +110,7 @@ $("#open_close_accordion a").click(function(){
 
     <section class="book">
       <section class="page">
-        <nav>
+        <nav aria-label="${_('Page')}">
           <ul>
             <li class="last">
               <a href="javascript:prev_page()">${_('Previous page')}</a>
diff --git a/lms/templates/verify_student/midcourse_photo_reverification.html b/lms/templates/verify_student/midcourse_photo_reverification.html
index 6515cc09cb..744cf448e3 100644
--- a/lms/templates/verify_student/midcourse_photo_reverification.html
+++ b/lms/templates/verify_student/midcourse_photo_reverification.html
@@ -159,7 +159,7 @@
 
               <img id="face_image" src="" style="display: none;"/>
 
-              <nav class="nav-wizard" id="face_id_next_button_nav">
+              <nav class="nav-wizard" id="face_id_next_button_nav" aria-label="${_('Verification')}">
                 <div class="prompt-verify">
                   <h3 class="title">Before proceeding, please review carefully</h3>
 
diff --git a/lms/templates/verify_student/photo_reverification.html b/lms/templates/verify_student/photo_reverification.html
index 2f23fa4f3e..f5c18b9c9f 100644
--- a/lms/templates/verify_student/photo_reverification.html
+++ b/lms/templates/verify_student/photo_reverification.html
@@ -183,7 +183,7 @@
                 </div>
               </div>
 
-              <nav class="nav-wizard" id="face_next_button_nav">
+               <nav class="nav-wizard" id="face_next_button_nav" aria-label="${_('Verification')}">
                 <span class="help help-inline">${_("Once you verify your photo looks good, you can move on to step 2.")}</span>
 
                 <ol class="wizard-steps">
@@ -271,7 +271,7 @@
                 </div>
               </div>
 
-              <nav class="nav-wizard" id="photo_id_next_button_nav">
+              <nav class="nav-wizard" id="photo_id_next_button_nav" aria-label="${_('Verification')}">
                 <span class="help help-inline">${_("Once you verify your ID photo looks good, you can move on to step 3.")}</span>
 
                 <ol class="wizard-steps">
@@ -364,7 +364,7 @@
                 </ol>
               </div>
 
-              <nav class="nav-wizard">
+              <nav class="nav-wizard" aria-label="${_('Verification')}">
                 <div class="prompt-verify">
                   <h3 class="title">Before proceeding, please confirm that your details match</h3>
 

From d116f84c12fb9c0dd43a433f6f9948a1ceebe799 Mon Sep 17 00:00:00 2001
From: Ahsan Ulhaq <ahsan.haq@arbisoft.com>
Date: Thu, 5 Mar 2015 15:13:21 +0500
Subject: [PATCH 2/2] Removed aria label from section tag

---
 lms/templates/discussion/user_profile.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lms/templates/discussion/user_profile.html b/lms/templates/discussion/user_profile.html
index c13711279b..fae5d837bf 100644
--- a/lms/templates/discussion/user_profile.html
+++ b/lms/templates/discussion/user_profile.html
@@ -22,7 +22,7 @@
 
 <section class="container">
   <div class="course-wrapper">
-    <section aria-label="${_('User Profile')}" class="user-profile">
+    <section class="user-profile">
       <nav aria-label="${_('User Profile')}">
 
         <article class="sidebar-module discussion-sidebar">